Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/storage/wal: fix oss-fuzz issue 44433 #13689

Merged
merged 1 commit into from
Feb 14, 2022
Merged

server/storage/wal: fix oss-fuzz issue 44433 #13689

merged 1 commit into from
Feb 14, 2022

Conversation

AdamKorcz
Copy link
Contributor

spzala
spzala reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdamKorcz It looks good to me but a small suggestion - considering multiple use of int(number) and enum.Values() it would be nice to create variables for them.

serathius
serathius approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ptabor @ahrtr

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #13689 (674cc7c) into main (bba3937) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

❗ Current head 674cc7c differs from pull request most recent head 0fcb2a6. Consider uploading reports for the commit 0fcb2a6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13689      +/-   ##
==========================================
- Coverage   72.77%   72.72%   -0.06%     
==========================================
  Files         465      465              
  Lines       37865    37915      +50     
==========================================
+ Hits        27556    27573      +17     
- Misses       8535     8562      +27     
- Partials     1774     1780       +6
Flag Coverage Δ
all 72.72% <60.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/wal/version.go 52.76% <60.00%> (-0.07%) ⬇️
client/v3/txn.go 73.33% <0.00%> (-26.67%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
server/storage/mvcc/watchable_store.go 85.14% <0.00%> (-3.99%) ⬇️
server/etcdserver/api/v3election/election.go 66.66% <0.00%> (-2.78%) ⬇️
server/etcdserver/api/v3rpc/watch.go 85.90% <0.00%> (-2.02%) ⬇️
server/etcdserver/api/rafthttp/peer.go 85.06% <0.00%> (-1.95%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 71.30% <0.00%> (-1.74%) ⬇️
server/storage/mvcc/index.go 91.08% <0.00%> (-1.59%) ⬇️
server/storage/mvcc/kvstore_txn.go 75.27% <0.00%> (-1.10%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba3937...0fcb2a6. Read the comment docs.

spzala
spzala approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments quickly @AdamKorcz

@spzala spzala merged commit aa75fd0 into etcd-io:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

@spzala spzala spzala approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamKorcz @codecov-commenter @serathius @spzala @ahrtr